summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNirbheek Chauhan <nirbheek@centricular.com>2014-07-14 10:04:44 (GMT)
committerNirbheek Chauhan <nirbheek@centricular.com>2014-07-14 10:05:31 (GMT)
commit6b6320e9e043d3f3759df64a7d543a1d55669bec (patch)
tree32f51aa876ebf91a672509ec0b102904ee9ccbcf
parente3b7d577b4c1ec7c2c53be3d87506c206ec07ffc (diff)
downloadsoup-transcoding-proxy-6b6320e9e043d3f3759df64a7d543a1d55669bec.zip
soup-transcoding-proxy-6b6320e9e043d3f3759df64a7d543a1d55669bec.tar.gz
Add two FIXMEs pointed out by slomo in his review
WIP
-rw-r--r--src/lib.c1
-rw-r--r--src/main.c3
2 files changed, 4 insertions, 0 deletions
diff --git a/src/lib.c b/src/lib.c
index 115249a..01bae81 100644
--- a/src/lib.c
+++ b/src/lib.c
@@ -44,6 +44,7 @@ stp_on_gst_bus_message (GstBus *bus,
* hasn't already finished, so we check that */
if (!ctx->stream_finished)
soup_message_set_status (ctx->msg, SOUP_STATUS_INTERNAL_SERVER_ERROR);
+ /* FIXME: hash tables are not threadsafe */
g_hash_table_remove (ctx->parent_ctx_table, ctx->path);
break;
case GST_MESSAGE_EOS:
diff --git a/src/main.c b/src/main.c
index 000c6ba..108b465 100644
--- a/src/main.c
+++ b/src/main.c
@@ -124,6 +124,9 @@ write_client_chunk_cb (GstElement *appsink,
GstBuffer *buffer;
gboolean eos;
+ /* FIXME: Maybe dispatch to libsoup's main loop and do
+ * everything from there instead?
+ */
if (!g_mutex_trylock (&ctx->can_write_chunk)) {
stp_print_status ("!");
/* We cannot safely append to the message body till