diff options
author | Nirbheek Chauhan <nirbheek@centricular.com> | 2014-07-14 10:04:44 (GMT) |
---|---|---|
committer | Nirbheek Chauhan <nirbheek@centricular.com> | 2014-07-14 10:05:31 (GMT) |
commit | 6b6320e9e043d3f3759df64a7d543a1d55669bec (patch) | |
tree | 32f51aa876ebf91a672509ec0b102904ee9ccbcf | |
parent | e3b7d577b4c1ec7c2c53be3d87506c206ec07ffc (diff) | |
download | soup-transcoding-proxy-6b6320e9e043d3f3759df64a7d543a1d55669bec.zip soup-transcoding-proxy-6b6320e9e043d3f3759df64a7d543a1d55669bec.tar.gz |
Add two FIXMEs pointed out by slomo in his review
WIP
-rw-r--r-- | src/lib.c | 1 | ||||
-rw-r--r-- | src/main.c | 3 |
2 files changed, 4 insertions, 0 deletions
@@ -44,6 +44,7 @@ stp_on_gst_bus_message (GstBus *bus, * hasn't already finished, so we check that */ if (!ctx->stream_finished) soup_message_set_status (ctx->msg, SOUP_STATUS_INTERNAL_SERVER_ERROR); + /* FIXME: hash tables are not threadsafe */ g_hash_table_remove (ctx->parent_ctx_table, ctx->path); break; case GST_MESSAGE_EOS: @@ -124,6 +124,9 @@ write_client_chunk_cb (GstElement *appsink, GstBuffer *buffer; gboolean eos; + /* FIXME: Maybe dispatch to libsoup's main loop and do + * everything from there instead? + */ if (!g_mutex_trylock (&ctx->can_write_chunk)) { stp_print_status ("!"); /* We cannot safely append to the message body till |