From 6b6320e9e043d3f3759df64a7d543a1d55669bec Mon Sep 17 00:00:00 2001
From: Nirbheek Chauhan <nirbheek@centricular.com>
Date: Mon, 14 Jul 2014 15:34:44 +0530
Subject: Add two FIXMEs pointed out by slomo in his review

WIP
---
 src/lib.c  | 1 +
 src/main.c | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/src/lib.c b/src/lib.c
index 115249a..01bae81 100644
--- a/src/lib.c
+++ b/src/lib.c
@@ -44,6 +44,7 @@ stp_on_gst_bus_message (GstBus             *bus,
        * hasn't already finished, so we check that */
       if (!ctx->stream_finished)
         soup_message_set_status (ctx->msg, SOUP_STATUS_INTERNAL_SERVER_ERROR);
+      /* FIXME: hash tables are not threadsafe */
       g_hash_table_remove (ctx->parent_ctx_table, ctx->path);
       break;
     case GST_MESSAGE_EOS:
diff --git a/src/main.c b/src/main.c
index 000c6ba..108b465 100644
--- a/src/main.c
+++ b/src/main.c
@@ -124,6 +124,9 @@ write_client_chunk_cb (GstElement         *appsink,
   GstBuffer *buffer;
   gboolean eos;
 
+  /* FIXME: Maybe dispatch to libsoup's main loop and do
+   * everything from there instead?
+   */
   if (!g_mutex_trylock (&ctx->can_write_chunk)) {
     stp_print_status ("!");
     /* We cannot safely append to the message body till
-- 
cgit v0.11.2-2-gd1dd